Bart Koelman

Results 276 comments of Bart Koelman

Related: https://github.com/actions/runner-images/issues/9834#issuecomment-2117426283

I'm afraid this bug has become a "feature", ie people may be relying on the current behavior and we shouldn't break them in a minor or patch release.

@verdie-g Do you still intend to complete this?

> Hi @bkoelman, I'll try finishing that PR. Could you have a pass on its current state, I'll add tests for Kiota once the one for NSwag start looking okay....

> I've completed the table except the EF Core column which I think is out-of-scope for this PR. I've mentioned earlier that the goal of writing end-to-end tests is to...

The table update isn't correct. The Y/N columns need to move. ![image](https://github.com/json-api-dotnet/JsonApiDotNetCore/assets/10324372/2b35d45f-614c-4bde-badb-0b7a1b4fc47a) The same applies to: `[Compare]`, `[AllowedValues]`, `[DeniedValues]`, `[Remote]`, and `[ValidateNever]`.

> > Both (remove culture and change assertions) haven't been addressed yet. > > I'm not able to access the comment to answer but I could you clarify what you...

Related: https://github.com/github/how-engineering-communicates/blob/main/quick-ref.md

Thanks, I'll take a look next week.

Superseded by #1718.