dotenv icon indicating copy to clipboard operation
dotenv copied to clipboard

Environment loading change in 2.7.6 is wrong

Open amilligan opened this issue 4 years ago • 6 comments

This pull request changed the default rake task to force load the Rails test environment.

Setting aside any argument about how test vs. development environment in rake, installing a gem should not change the behavior of the default rake task. Not every rake task is for running tests, and the default rake task very well may include tasks that are not test-specific.

To reproduce, simply create a default rake task with non-test tasks. We use license_finder, brakeman, etc. Given a non-test tasks dependent on running in the development environment the default task fails, fails to run, or gives incorrect results.

amilligan avatar Jul 20 '20 14:07 amilligan

Apologies, I'll get this rectified today.

cadwallion avatar Jul 20 '20 14:07 cadwallion

Thanks, we appreciate it.

amilligan avatar Jul 20 '20 15:07 amilligan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 20 '20 04:09 stale[bot]

@cadwallion Any chance of an update on this? I'm happy to provide a pull request, but I suspect it would just be a revert of the commit that made the change.

amilligan avatar Sep 20 '20 16:09 amilligan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 19 '20 09:12 stale[bot]

!notstale

taylorthurlow avatar Dec 19 '20 18:12 taylorthurlow