react-native-incoming-call icon indicating copy to clipboard operation
react-native-incoming-call copied to clipboard

Use maven-publish to support React Native 0.67.1

Open geraintwhite opened this issue 2 years ago • 8 comments

Based on https://github.com/software-mansion/react-native-reanimated/pull/2881

Fixes #33

geraintwhite avatar Jun 01 '22 14:06 geraintwhite

hi, how can i get this patch using npm? Thanks so much

fukemy avatar Oct 25 '22 04:10 fukemy

@grit96 Could you please provide either patch with npm or short summary of how to fix this bug?

HalilFocic avatar Nov 04 '22 12:11 HalilFocic

Hi, I'm not the maintainer of this repo. You can manually make the changes and use patch-package to preserve them.

geraintwhite avatar Nov 04 '22 13:11 geraintwhite

I would be willing to take over maintainership if @bkdev98 will allow it.

geraintwhite avatar Nov 04 '22 13:11 geraintwhite

@grit96 Could you please provide either patch with npm or short summary of how to fix this bug?

U can use https://github.com/linhvovan29546/react-native-full-screen-notification-incoming-call instead

fukemy avatar Nov 04 '22 13:11 fukemy

Did anyone figure out how to make this package work with newer react-native versions like 0.73.5 ?

Even after applying the patch provided by @geraintwhite, I get the following error:

A problem occurred configuring project ':react-native-incoming-call'.
> Could not resolve all files for configuration ':react-native-incoming-call:implementation'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :react-native-incoming-call
      > Cannot choose between the following variants of com.facebook.react:react-android:0.73.5:
          - debugVariantDefaultRuntimePublication
          - releaseVariantDefaultRuntimePublication
        All of them match the consumer attributes:
          - Variant 'debugVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'debug' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
          - Variant 'releaseVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'release' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it

rohinipf avatar Mar 14 '24 11:03 rohinipf

Did anyone figure out how to make this package work with newer react-native versions like 0.73.5 ?

Even after applying the patch provided by @geraintwhite, I get the following error:

A problem occurred configuring project ':react-native-incoming-call'.
> Could not resolve all files for configuration ':react-native-incoming-call:implementation'.
   > Could not resolve com.facebook.react:react-native:+.
     Required by:
         project :react-native-incoming-call
      > Cannot choose between the following variants of com.facebook.react:react-android:0.73.5:
          - debugVariantDefaultRuntimePublication
          - releaseVariantDefaultRuntimePublication
        All of them match the consumer attributes:
          - Variant 'debugVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'debug' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
          - Variant 'releaseVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.73.5:
              - Unmatched attributes:
                  - Provides com.android.build.api.attributes.BuildTypeAttr 'release' but the consumer didn't ask for it
                  - Provides org.gradle.category 'library' but the consumer didn't ask for it
                  - Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
                  - Provides org.gradle.libraryelements 'aar' but the consumer didn't ask for it
                  - Provides org.gradle.status 'release' but the consumer didn't ask for it
                  - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
exclusiveContent {
            // We get React Native's Android binaries exclusively through npm,
            // from a local Maven repo inside node_modules/react-native/.
            // (The use of exclusiveContent prevents looking elsewhere like Maven Central
            // and potentially getting a wrong version.)
            filter {
                includeGroup "com.facebook.react"
            }
            forRepository {
                maven {
                    url "$rootDir/../node_modules/react-native/android"
                }
            }
        }

fukemy avatar Mar 15 '24 01:03 fukemy

exclusiveContent {
            // We get React Native's Android binaries exclusively through npm,
            // from a local Maven repo inside node_modules/react-native/.
            // (The use of exclusiveContent prevents looking elsewhere like Maven Central
            // and potentially getting a wrong version.)
            filter {
                includeGroup "com.facebook.react"
            }
            forRepository {
                maven {
                    url "$rootDir/../node_modules/react-native/android"
                }
            }
        }

@fukemy I dumped this under repositories like below but I still receive the same error. Was I supposed to place it somewhere else? Maybe under the buildscript ?

repositories {
    // ref: https://www.baeldung.com/maven-local-repository
    mavenLocal()
    maven {
        // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
        url "$rootDir/../node_modules/react-native/android"
    }
    maven {
        // Android JSC is installed from npm
        url "$rootDir/../node_modules/jsc-android/dist"
    }
    google()
    jcenter()

    exclusiveContent {
        // We get React Native's Android binaries exclusively through npm,
        // from a local Maven repo inside node_modules/react-native/.
        // (The use of exclusiveContent prevents looking elsewhere like Maven Central
        // and potentially getting a wrong version.)
        filter {
            includeGroup "com.facebook.react"
        }
        forRepository {
            maven {
                url "$rootDir/../node_modules/react-native/android"
            }
        }
    }
}

rohinipf avatar Mar 15 '24 04:03 rohinipf