lnxlink icon indicating copy to clipboard operation
lnxlink copied to clipboard
verified publisher icon bkbilly

More granular state monitoring in gamepad.py

Open jackhric opened this issue 1 year ago • 4 comments

  • Added more detailed state monitoring of gamepads (On, Off, Inactive)
  • Handling for when a controller is disconnected
  • Increased default time-out to 60sec instead of 40sec

jackhric avatar Jul 23 '24 16:07 jackhric

@jackhric In less than a week I'll release the new version of LNXlink. If you want your changes to be available on the new version, you should look at the changes I suggested.

bkbilly avatar Jul 28 '24 11:07 bkbilly

Currently poking around for said changes and suggestions; where should I look?

jackhric avatar Aug 14 '24 18:08 jackhric

Can't you see the review comments I wrote above?

Basically wrote that the ON/OFF are confusing and they should be replaced with Active, Inactive and Disconnected. Also there are some issues with the code format. You should pass it through pre-commit to check if everything is correct:

pre-commit run --all-files

bkbilly avatar Aug 14 '24 21:08 bkbilly

Didn't see any review comments. This is my first pull request, so I might be missing something on my end. Will update and get back.

jackhric avatar Aug 15 '24 00:08 jackhric

No activity on this Pull Request recently. If no further activity occurs, this PR will be closed. Thank you for your contributions.

github-actions[bot] avatar Sep 24 '24 20:09 github-actions[bot]