Hitch icon indicating copy to clipboard operation
Hitch copied to clipboard

Improved performace

Open EvandroLG opened this issue 11 years ago • 5 comments

It's best to access local variables than global

EvandroLG avatar Apr 08 '14 18:04 EvandroLG

I like this, but we are working on a complete rewrite to align with the css aliases working draft that we helped inspire..not sure it's worth messing with the 0.6.x codebase at this point. What do you think?

bkardell avatar Apr 09 '14 14:04 bkardell

It's great. I think we can update, because it's a very simple change - it's not a dangerours change.

Are you working in a engine-model-restructure branch? If so, I want help you, man ;)

My best

2014-04-09 11:35 GMT-03:00 Brian Kardell [email protected]:

I like this, but we are working on a complete rewrite to align with the css aliases working draft that we helped inspire..not sure it's worth messing with the 0.6.x codebase at this point. What do you think?

Reply to this email directly or view it on GitHubhttps://github.com/bkardell/Hitch/pull/32#issuecomment-39970983 .

Att, Evandro

EvandroLG avatar Apr 09 '14 15:04 EvandroLG

No this is actually the next branch and it is a really really significant change, basically a complete reboot to align with the actual proposal that is developing. We want to fill the proposal and allow people to use it and provide feeback/improve it.

If you're actually using Hitch and feel that there is value in a minor update, please have a look at the couple of open pulls and let us know which you feel are valuable to you and we can consider that. We keep thinking that we are going to get time to drive things forward, but everything is time consuming as things are still gelling, so I cannot really give some ETA. @clintjhill may have comments/thoughts

bkardell avatar Apr 09 '14 16:04 bkardell

I've reviewed the PR and I'd say that while this is a great set of updates - I'd prefer to just focus on the /next branch instead. I'm of the opinion that performance related improvements to previous version would be misplaced efforts.

Brian and I are coordinating a push to the /next branch soon and we'd love your participation there. As Brian mentioned it's a reboot. We'd love your eyes on it for the same kinds of perf updates you applied here.

clintjhill avatar Apr 09 '14 20:04 clintjhill

Worth mentioning that what is committed in github is probably out of date and requiring expanation that you wont find here... maybe we can move some of that discussion public and get the commits up to date

On Wed, Apr 9, 2014 at 4:49 PM, Clint Hill [email protected] wrote:

I've reviewed the PR and I'd say that while this is a great set of updates

  • I'd prefer to just focus on the /next branch instead. I'm of the opinion that performance related improvements to previous version would be misplaced efforts.

Brian and I are coordinating a push to the /next branch soon and we'd love your participation there. As Brian mentioned it's a reboot. We'd love your eyes on it for the same kinds of perf updates you applied here.

Reply to this email directly or view it on GitHubhttps://github.com/bkardell/Hitch/pull/32#issuecomment-40014561 .

Brian Kardell :: @briankardell :: hitchjs.com

bkardell avatar Apr 09 '14 21:04 bkardell