GENie icon indicating copy to clipboard operation
GENie copied to clipboard

Makefile wholearchive responsefile support

Open KageKirin opened this issue 5 years ago • 6 comments

Hi,

this is the PR for the follow up changes to #456 I mentioned in the latter's PR. This PR adds handling of wholearchive libs with responsefiles. (Simply said, I had to link several libs as wholearchive for Android, and ran into this self-created bug).

The actual changes from this PR starts after b5a3826, the part before being the previous work to be as #456.

Cheers.

CC @rhoot for review as well, please.

KageKirin avatar Jul 11 '19 06:07 KageKirin

On second thought, I think it would be easier to just review and merge this PR instead of the 2.

KageKirin avatar Jul 12 '19 02:07 KageKirin

I'm still testing, but I think I have a fix for the issue raised by @rhoot. Please tell me if you think this version is acceptable to be merged.

KageKirin avatar Jul 24 '19 09:07 KageKirin

So, I finished testing this (by building my work project for Android), and it works.

@rhoot Could you please review this again? Thanks.

KageKirin avatar Jul 25 '19 14:07 KageKirin

Hey @bkaradzic and @rhoot, since this PR has been around for quite some time now, would you mind reviewing it, please?

Especially if there are things to fix or improve, I'd like to get feedback about them. Cheers.

KageKirin avatar Aug 29 '19 05:08 KageKirin

Happy thanksgiving. Maybe we can merge this now? Pretty please.

KageKirin avatar Nov 28 '19 07:11 KageKirin

Yeah waiting for @rhoot to review it...

bkaradzic avatar Nov 28 '19 17:11 bkaradzic