language-python icon indicating copy to clipboard operation
language-python copied to clipboard

Disable redefining __GLASSGOW_HASKELL__ to fix compatibility with Happy 2.0.x

Open bramvdbogaerde opened this issue 1 year ago • 1 comments

This PR fixes issue #77.

NOTE: I would like to remove the redefine entirely but since I am not sure what it's initial purpose was I only disable it for versions above GHC 9.1 which coincidentally correspond to the versions that do not perform an explicit type conversion from Int32# to Int#.

bramvdbogaerde avatar Sep 25 '24 12:09 bramvdbogaerde

Hi, I've also hit this and can confirm it fixes the issue.

tych0 avatar Oct 06 '24 16:10 tych0

I can confirm that this fixes it for me when building for Arch. The hack was added for #41 but I think it's not a problem now - with this PR I could build it within one minute on GHC 9.2.4.

felixonmars avatar Nov 19 '24 19:11 felixonmars

Ping @bjpop . Can this fix be released to Hackage?

andreasabel avatar Mar 27 '25 16:03 andreasabel

Apologies for the delay. Will look into this soon.

bjpop avatar Mar 30 '25 04:03 bjpop