jvectormap
jvectormap copied to clipboard
Published
20 hours ago •
bjornd
bjornd
Add input checks in processor.py...
Great project! I just bought a license because I created a GEO chart for a client.
Today I tried using the converter following your document examples for the Dutch map but I bumped into a number of issues.
- [ ] 0. Mainly the
processor.pyscript does NO input checking whatsoever. For a tool that is meant to be used by others (and even offered on a commercial license) I would say that is not very proficient. I'll issue a pull request, of two small additions I did which would have saved me some time.
About the other issues:
- [ ] 1. Only cosmetics, but I believe on your site a while back on the maps you started with a world map. But now it's showing South America, which - to me - makes much less sense: http://jvectormap.com/maps/world (Are you having a routing problem maybe? :smile: )
- [ ] 2. The examples - at least the one for the Netherlands - don't specify a 'file_name' in the
write_datasection. You should probably specifyfile_name": "jquery-jvectormap-nl-mill.json the website. I realize that's a lot of work to do for all maps. As they are they generate an error immediately, which throws of a newb user. The map examples are great by the way. That's what made me purchase :smile:. Simpler fix is improve the input checks, see issue 0. - [ ] 3. You specify on the your website about the converter:
In order to run the converter you need python version 2.7 or **later**..
I'm a relative Python newb so I went on confidently using Python 3.4, since that is later. But you really need Python 2, so you should better specify something like:
In order to run the converter you need python version 2.7 or later **(but <3.0)**..
Well, I managed to replicate your example, but now I want to join some provinces to a region. And it's not entirely clear to me how to proceed. Is there any change for support? Via binpress.com?
