bjorn3

Results 1108 comments of bjorn3

Does https://github.com/bjorn3/rustc_codegen_cranelift/commit/53e51acc2fb7782ead73e8e18a9b5d3241235555 seem like a good way to support this? (I know I forgot setting `%al`)

> but I would think that support for calling variadic functions would need to be added to cranelift itself instead of rustc_codegen_cranelift. Cranelift is more low level than LLVM. Eg...

1. for sysv you can ignore varargsness when calling it (except for %al) just pretend that it always has the exact types and number of values you pass. 2. you...

What I did for cg_clif is dont tell cranelift_module about the varargs and then use declare_func_in_func once per vararg call. That will give a unique FuncRef every time. I then...

Yes, the `Function` you build is competely mutable. You can rewrite any part you want.

RegDiversions is only used when regalloc is running or has already ran. For your usecase you will want to use `AbiParam::special_reg` in the `Signature`. You can get the `RegUnit` by...

There hasn't been any change since the last comment here. Also do you need just support for calling variadic functions or also defining them? The former is a lot easier...

Once libstd switches to parking-lot for mutexes, coz won't work correctly anymore, as it expects pthread mutexes.

I believe wasm32-unknown-unknown is intended to be free from C code. Wasm32-wasi can enable it though. Wasi-libc is already written in C anyway.

Maybe require that output of the latest pass has strictly less bytes/tokens than the output of the previous pass? That would guarantee that it stops, as eventually you are left...