bjoluc
bjoluc
Thanks for bumping, @DominiqueMakowski! @jspsych/core What do you think about baking this into the survey plugin and releasing it in a patch version? I don't think the pattern is common...
I think we ultimately wanted to allow pushing trials/timelines to timeline definitions at runtime for this. I forgot to add the omission to the changeset when implementing the new core...
#3426 allows pushing trials to timelines at run time. Only that it's not yet documented and obviously the `jsPsych.addNodeToEndOfTimeline()` docs need to be fixed (ideally also the v8 mirgation guide)....
@jodeleeuw When you updated the dependencies, including esbuild from 0.15.14 to 0.23.1 in 59ce0b3, did you read the changelogs? There seem to be a lot of breaking changes in esbuild...
@jodeleeuw I double-checked and committed the rollup dependency updates in #3396 – they're all welcome and independent of the .json issue. Re that issue: Because we are using esbuild via...
> but it required adding some declare const statements at the top of the plugin ts templates and that felt unnecessarily confusing for rookie devs. Have you thought about declaring...
Hi all, I just received the notification mail and had a quick look at the diff. I think I would much prefer replacing a `__CITATIONS__` reference (with a global TS...
I've run into this too. The issue stems from type widening in the meta `args` type inference: ## The Why When we write https://github.com/storybookjs/storybook/blob/453d7546d0099f40b4e110fbd967517d6dc5b7d4/code/renderers/react/src/preview.tsx#L61 and https://github.com/storybookjs/storybook/blob/453d7546d0099f40b4e110fbd967517d6dc5b7d4/code/renderers/react/src/preview.tsx#L67 our ```ts args: {...
I can think of two ways to fix this: (1) Marking the `story` parameter of the `story` function required in general. Seems consistent with CSF3 and would avoid any extra...
@IanVS This might be intended behavior, but the error is not obvious: When a render function without an args parameter is passed to the `story` method (either directly, or in...