Sebastian Beltran comments

Results 422 comments of


                                            Sebastian Beltran

add `path.mimeType()` and `path.charset()` to `node:path`

By the way, if it helps in the future when this conversation comes up again, mime-db doesn't strictly follow semver since the records can change (see https://github.com/jshttp/mime-db/issues/331, https://github.com/jshttp/mime-db/pull/330) and break...

feat: Moving types into the repo

@RobinTail, the meeting is in 4 hours. https://github.com/expressjs/discussions/issues/344

docs: include a dependencies navigator

This PR needs to be opened in the discussions repo, since it will be removed from here

Discussion: Let's talk about HISTORY.md

This should be automated to avoid opening unnecessary PRs for updating the history or delaying the same PRs for something that can be automated. I believe the popular way to...

Discussion: Let's talk about HISTORY.md

Updating the history also causes conflicts with other PRs that are also updating their history for their PR, which blocks the PR until the author fixes it, or if they...

use writableEnd instead finished

@UlisesGascon @Phillip9587 I’d prefer to make this change for version 2, and it can be backported to v3.

use writableEnd instead finished

done, i’ve already done the rebase

TypeError: ee.on is not a function

Hey @leoflood, I’m not entirely familiar with Lambdas, but could you give us more information, like which version of Node it uses, the version of Express, etc.?

feat: http2 support

Currently, there is a test that, although it is not failing, is still showing a warning in Node.js. I will need to investigate the best way to proceed ![image](https://github.com/user-attachments/assets/e5a2f3f1-8278-41ec-8872-c72edb9a06b8)

feat: http2 support

@jshttp/express-tc given that `writeHead` can receive a string as the second parameter, which is not supported in HTTP/2, should we throw an error?