vasppy icon indicating copy to clipboard operation
vasppy copied to clipboard

`Doscar` does not handle ISPIN = 1 calculations correctly.

Open alexsquires opened this issue 3 years ago • 8 comments

Doscar.tdos dataframe is mislabeled (possibly incorrect) when setting ispin=1. For the same vasp calculation with ISPIN = 2 and ISPIN = 1, these are the dataframes returned by vasppy

image

alexsquires avatar Aug 09 '21 10:08 alexsquires

The same calculation, or different calculations on the same system (one spin-polarised, the other non-spin-polarised)?

bjmorgan avatar Aug 09 '21 10:08 bjmorgan

two different calculations on the same system (LiF).

alexsquires avatar Aug 09 '21 10:08 alexsquires

Is it possible to attach the two DOSCARs? (should these give the same result in both cases? In the output above the energies and integrated DOS appear different?)

bjmorgan avatar Aug 09 '21 10:08 bjmorgan

Seems like they are too big. I could rerun with a coarse DOS?

alexsquires avatar Aug 09 '21 10:08 alexsquires

(should these give the same result in both cases? In the output above the energies and integrated DOS appear different?)

I would have assumed so (the only thing that changed between the two calculations was ISPIN)

alexsquires avatar Aug 09 '21 10:08 alexsquires

Would be nice to have a minimal example that I can e.g. write some proper tests against.

bjmorgan avatar Aug 09 '21 10:08 bjmorgan

@alexsquires I think this is fixed now in ecefd14b3f2de8658130f5f7d370f69099c3dd86 (currently only in the doscar_nsp branch). Can you please test?

bjmorgan avatar Sep 10 '22 17:09 bjmorgan

Sorry for the late response, this does fix the initial issue.

alexsquires avatar Dec 14 '22 13:12 alexsquires