Brendan McCollam

Results 47 comments of Brendan McCollam

@pix27 Did you ever find a workaround for this? I'm trying to apply `routerLink` on a `` but it adds an extra tabstop and users would have to tab twice.

I'd like to see this change - we were just surprised by this. @psychedelicious have you made a start on an implementation? Any way I could help? This especially shows...

Thank you for such a thoughtful and detailed response. I'm going to have to chew on this a bit as we define our testing practices for this project.

The only [test failures](https://github.com/pydantic/pydantic/actions/runs/9195205949/job/25290459935) look to be with an older version of mypy. Maybe it doesn't fully recognize the protocols from `annotated_types`?

@dmontagu Good shout, I'll revert those.

I was overgeneralizing from the `metadata_lookup` [here](https://github.com/pydantic/pydantic/blob/afe67c0a9af244ef2abb726810c5e5db3c680641/pydantic/fields.py#L180) but you're absolutely right those are dataclasses to store the constraints, not Protocols to describe input types. I've reverted them now. I suppose...

@sydney-runkle - Confirming this fixes my issue, using the same `example.py` from #9472 : ``` bjmc@host:~/Sandbox/pydantic$ git checkout main Switched to branch 'main' Your branch is up to date with...

I'm not a typing wizard, but I wonder if a good resolution here would be to use the [comparison protocols defined by typeshed](https://github.com/python/typeshed/blob/f4ae363b564de69bfad4b4346204a25a99cd6642/stdlib/_typeshed/__init__.pyi#L52) for these field validators? I'm happy to...

I agree that `annotated_types` is better since it's already a dependency.