Bill Little

decorator hash_library kwarg option precedence

9

Within the `plugin.ImageComparison.compare_image_to_hash_library` method, should it not be the case that the `mpl_image_compare` marker `hash_library` kwarg option **should have precedence** over the `--mpl-hash-library` CLI argument? https://github.com/matplotlib/pytest-mpl/blob/e3876180847c2d04aeda1982372074998a7f8716/pytest_mpl/plugin.py#L520-L521 At the moment this...

default hash savefig format

13

This PR addresses issue #152, by ensuring that a default `format='png'` is injected to the `savefig` kwargs when generating a hash. Closes #152

Improving hash library workflow

2

For the current workflow, if there are hash library test failures for a `pytest` session, then these are easily discoverable thanks to the rich loveliness of the `html` figure comparison....

result_image redundancy

3

In the `plugin.ImageComparison.compare_image_to_hash_library` method, during `hybrid-mode`, the `result_image` appears to be unnecessarily copied into the `summary` dictionary from the outcome of `plugin.ImageComparison.compare_image_to_baseline`: https://github.com/matplotlib/pytest-mpl/blob/e3876180847c2d04aeda1982372074998a7f8716/pytest_mpl/plugin.py#L571-L573 i.e., the `summary['result_image']` has already been correctly...

default savefig format

3

In the process of penning #150, I noticed that when capturing the test image to an `io.Bytes` in-memory buffer: https://github.com/matplotlib/pytest-mpl/blob/e3876180847c2d04aeda1982372074998a7f8716/pytest_mpl/plugin.py#L419-L421 That the `format` kwarg to `savefig` isn't used. Would you...

Perceptual Image Hash

11

Thanks and congrats on `pytest-mpl`. It's really lovely :+1: Over on [SciTools/iris](https://github.com/SciTools/iris) we've been using a very similar framework to perform graphical testing, but rather than using RMS or SHA-256...

## 🚀 Pull Request ### Description This PR addresses some long outstanding technical debt, which thanks to [pep518](https://peps.python.org/pep-0518/), we can finally tidy-up and simplify. As a side-effect, developers can now...

## 🚀 Pull Request ### Description This PR bumps some minimum dependency pins for `cftime`, `setuptools` and `setuptools-scm`. Note that, the `cftime` minimum pin here aligns with the minimum pin...

Bump download/upload artifact gha version

2

## 🚀 Pull Request ### Description Require to bump the version of the `download-artifact` and `upload-artifact` to the latest version (`@3` -> `@4`) consistently within the same pull-request.

## 🚀 Pull Request ### Description This PR ensures that the assets packaged for the PyPI sdist and wheel are as expected by performing an automated GHA check of the...