BJ Hargrave

icon indicating a website link https://blog.hargrave.dev icon indicating an email [email protected]

icon company @IBM icon location Vermont icon location I'm an open source developer at IBM. Committer at @ibm-granite-community, @instructlab, @osgi, @eclipse, @jakartaee, and @bndtools.

Results 64 issues of BJ Hargrave

Update assertpy/string.pyi to correct type of pattern arg

1 comment

The methods requires the pattern arg to be of type str, not Pattern.

Update assertpy/extracting.pyi so that kwargs are not required

1 comment

The recent change to better type the `sort` and `filter` kwargs had the side effect of making them required. So we fix to supply a default value for the typing...

maven-plugin: Does not handle multi-module projects where the top-level project is just a reactor

This code in the mojo: https://github.com/eclipse-dash/dash-licenses/blob/36a69147426fe649bdfcdc2605373127dd826890/maven-plugin/src/main/java/org/eclipse/dash/licenses/maven/LicenseCheckMojo.java#L177-L182 just returns without doing anything when the project is not the top-level project. But if the top-level project is just a reactor and not...

pickSHA: Improve pickSHA to handle pull_request_target and push

1 comment

To support use in pull_request_target target workflows, we need to use the pull_request.head.sha value for check-runs. We also better support push target workflows by using the after SHA value as...