Brandon Fish

Results 30 comments of Brandon Fish

I think this could be useful for example including/excluding Google Analytics code which you would only want after statically generating. ``` {{#static_only}} {{#static_only}} ``` or inversely ``` {{#dynamic_only}} {{/dynamic_only}} ```...

@laktek I think @smola is describing something like an in browser error page when parsing errors occur versus just logging to the console when template or css errors occur. For...

@thelucid Using the following identifiers I believe can help preserve comments in the css: ``` /*! */ ``` Example ``` /*! Copyright 2013 Author Here is the copyright */ ```...

@JonRowe I'm volunteering to maintain TruffleRuby support within RSpec. I'll follow up again once I've had a chance to review the existing PRs, conversations, and run the specs. cc: @eregon

I ran the test suite locally and saw 33 failures for `truffleruby-head`. At least 2 appeared to be addressed in https://github.com/rspec/rspec-core/pull/2942. **rspec-core** - [ ] 1) Spec file load errors...

I've submitted a possible fix for the `rspec-expectation` failures: https://github.com/rspec/rspec-expectations/pull/1364/files

Created a PR for a failing expectations spec: https://github.com/rspec/rspec-expectations/pull/1366

I've tracked this down to this `monitor.closed?` which hangs and never calls the underlying C extension method: https://github.com/celluloid/celluloid-io/blob/49c1021b435073cd7bc9a394658d273488f4105e/lib/celluloid/io/reactor.rb#L52 I would suspect an issue relating to the mutex here: https://github.com/oracle/truffleruby/blob/3b756ceddba635edb4a5673ab999a26f427074de/lib/truffle/truffle/cext_ruby.rb#L37 The...

@eregon Java thread dump: https://gist.github.com/bjfish/ab5b30e7a29c009d46a5db0d889d9df1 Ruby thread dump: https://gist.github.com/bjfish/8d4f1441f561038cef02c8fed9da876d