oidc-react icon indicating copy to clipboard operation
oidc-react copied to clipboard

ReactDOM.render is no longer supported in React 18. Use createRoot instead.

Open simenandre opened this issue 3 years ago • 2 comments

Tests are warning us that we are using a deprecated feature. It can be seen in this build: https://github.com/bjerkio/oidc-react/runs/7359386639?check_suite_focus=true

The full warning is this:

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

Seems like we have a few references to this in our tests, so if anyone wants to open a pull request fixing that it would be awesome!

simenandre avatar Jul 15 '22 14:07 simenandre

so if anyone wants to open a pull request fixing that it would be awesome!

I would love to do that. However , I can't seem to find the file where ReactDOM.render is called. Can you help me out please.

Ebukachuqz avatar Jul 20 '22 10:07 Ebukachuqz

If you open the step (collapsible) named Run yarn test, there should be some more details there.

PS: Currently on my mobile phone, so I couldn't verify 😅

simenandre avatar Jul 20 '22 21:07 simenandre

Fixed by #945

jamesdh avatar Mar 01 '23 18:03 jamesdh