oidc-react icon indicating copy to clipboard operation
oidc-react copied to clipboard

AuthContext should handle Authentication Error Response

Open mancioshell opened this issue 3 years ago • 6 comments

If any error occurs in Authentication Response, AuthContext skip hasCodeInUrl and enters in a loop calling userManager.signinRedirect() every time.

Maybe hasCodeInUrl should be parse error parameter as specified in the Authentication Error Response specification.

mancioshell avatar Mar 25 '21 09:03 mancioshell

I absolutely agree!

Maybe you wanna contribute to that? We have talked about improving the functionality of hasCodeInUrl and related functionality before (#313).

simenandre avatar Mar 25 '21 11:03 simenandre

@mancioshell what do you think about incorporating the way @pamapa mentioned, where we use oidc-client native functions? Mind you, have a look at #652. Personally, I think this can be solved with a similar PR like you've made in #552.

Regardless of what you end up doing, thank you so much for contributing! 🙏

simenandre avatar Jul 21 '21 17:07 simenandre

Is there any possibility, that you will solve this issue and add some error handling?

marlena-sliwinska avatar Feb 24 '23 12:02 marlena-sliwinska

Hi @marlena-sliwinska 👋

I don't think anyone is working on this, so feel free to contribute! You can join our Discord server (or post questions here) if you want help with anything in that regard. https://discord.gg/SXMpgmPq5F

simenandre avatar Mar 12 '23 08:03 simenandre