nestjs-slack icon indicating copy to clipboard operation
nestjs-slack copied to clipboard

postMessage returns void instead of response

Open ithan opened this issue 1 year ago • 1 comments

The postMessage function from https://github.com/bjerkio/nestjs-slack/blob/main/src/slack.service.ts#L109 should return the API response to work with it, for things like sending messages to a thread instead of void.

ithan avatar Oct 26 '22 12:10 ithan

I totally agree!

You might also notice that we have multiple ways to send a message to Slack, which is why we are returning void today. It makes sense to return a type that maybe have an API response. Does that make sense for your use case too?

On this topic, we might want to think about how we can create threads on all our sending methods.

simenandre avatar Oct 26 '22 13:10 simenandre