zxcvbn-php icon indicating copy to clipboard operation
zxcvbn-php copied to clipboard

Published 20 hours ago • verified publisher icon bjeavons

Add warning from user input

Open franmomu opened this issue 4 years ago • 2 comments

When the user input is the main cause, the warning message was empty.

I added one, but since I'm not a native speaker (as you can notice 😬), any suggestion for the message is more than welcome.

I also added some phpstan doc: https://phpstan.org/r/68533b15-9d58-4205-9a0f-5664c8aca3fe

franmomu avatar Apr 14 '20 20:04 franmomu

Coverage Status

Coverage increased (+0.005%) to 98.184% when pulling f1290dff17d1ea91cecaaf64cf62272b7463abc5 on franmomu:add_warning_user_input into dde9679ac7e906a241d74d32083fb03699d56b93 on bjeavons:master.

coveralls avatar Apr 14 '20 20:04 coveralls

Hello @franmomu, thank you for the PR and also for the test, very much appreciated! I want to come back to this and give this another review after more thought, the suggestion language has some unique context. Zxcvbn-PHP doesn't know why a call is passing user data so the suggestion shouldn't make too many assumptions.

bjeavons avatar Apr 21 '20 01:04 bjeavons