gnome-bluetooth-quick-connect icon indicating copy to clipboard operation
gnome-bluetooth-quick-connect copied to clipboard
verified publisher icon bjarosze

Quick code review

Open hadess opened this issue 3 years ago • 2 comments

Here are some comments about the code in the repository as it is today:

  • https://github.com/bjarosze/gnome-bluetooth-quick-connect/blob/master/power.js is unnecessary, the battery information is already exported through the battery-type, battery-percentage and battery-level properties in the BluetoothDevice object. There are also bug fixes in upower to export the battery information on even more devices.
  • connect is available through BluetoothClient.connect_service()
  • disconnect isn't made available, please file a new bug against gnome-bluetooth upstream

All this code is worth getting merged upstream, if you want. Happy to help if you encounter any problems on the gnome-bluetooth side.

hadess avatar Sep 30 '22 14:09 hadess

FYI https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2501

hadess avatar Sep 30 '22 23:09 hadess

disconnect isn't made available, please file a new bug against gnome-bluetooth upstream

bluetooth_client_connect_service() with connect set to False does that, :facepalm:

hadess avatar Oct 03 '22 14:10 hadess