stylelint-config-sass-guidelines icon indicating copy to clipboard operation
stylelint-config-sass-guidelines copied to clipboard

Add extension of stylelint-config-recommended

Open reginawang3495 opened this issue 3 years ago • 3 comments

Add stylelint-config-recommended since it turns on all the possible error rules within stylelint.

A few examples of why this is useful:

  • while the stylelint here has no opinions on duplicate properties, stylelint-config-recommended lints for several types of duplicates, eg declaration-block-no-duplicate-custom-properties and etc.
  • no-extra-semicolons
  • function-calc-no-invalid
  • named-grid-areas-no-invalid
  • no-invalid-double-slash-comments
  • etc

See here for all the errors that it lints for

reginawang3495 avatar May 09 '21 02:05 reginawang3495

I need to think on this some, this will be a major version bump as it will enable new rules and likely trigger lint for people using the current released version of this config.

bjankord avatar May 10 '21 13:05 bjankord

Well, you probably need a major version bump for the stylelint 14 migration.

Btw, if you want to extend stylelint-config-recommended, maybe you want to extend stylelint-config-recommended-scss instead (from the stylelint-scss team), which already takes care of adjusting the stylelint-config-recommended rules to account for cases where a scss-specific rule must be used instead.

stof avatar Oct 29 '21 14:10 stof

I am not planning to release this in the next major version (v9.0.0) but I am considering possibly extending stylelint-config-recommended-scss instead in a v10.0.0 release.

bjankord avatar Oct 30 '21 12:10 bjankord

Thought about this and at this point I'm not wanting to bring this into this repo. If you want though, I think you should be able to extend stylelint-config-recommended and then extend stylelint-config-sass-guidelines in your own application.

bjankord avatar Mar 13 '23 23:03 bjankord