Brice Jaglin

Results 255 comments of Brice Jaglin

FTR, not fixed as of ``` [error] (expect2_13Target3_5_0-RC6 / Test / test) sbt.TestsFailedException: Tests unsuccessful [error] (expect2_13Target3_3_4-RC1 / Test / test) sbt.TestsFailedException: Tests unsuccessful ``` (tested via https://github.com/scalacenter/scalafix/pull/1951)

@tgodzik no warning is emitted by the compiler, I guess it's just a missing feature ```scala // UnusedParams.scala import java.util.List object UnusedParams { val f: String => Unit = unused...

Actually, it looks like an issue for that was recently filed: https://github.com/scala/scala3/issues/20951

Hi @BalmungSan! > However, unless I am missing something like a compiler bug or bad practice (and if that is the case I would highly appreciate the feedback), I think...

> the rule could be extended to check if the `final val` has an explicit type annotation Thanks for clarifying. I am no expert either, but I agree it makes...

This likely comes from [changes in implicit resolution](https://docs.scala-lang.org/scala3/reference/changed-features/implicit-resolution.html): > Package prefixes no longer contribute to the implicit search scope of a type

Hi @mrdziuban, thanks for reporting back here and sorry for the delay. That `fatalWarnings` flag seems unused and is not exposed as a CLI arg. Judging by the git history,...

Actually, I take back what I said... I just realised after exploring the test suites that there is already a pretty advanced yet undocumented CLI flag that allows to override...

Thanks for the feedback. I documented our respective findings (as well as the `.scalafix.conf` / CLI args duality) through https://github.com/scalacenter/scalafix/pull/2062. It's live at https://scalacenter.github.io/scalafix/docs/users/configuration.html#overriding-the-linting-behavior and below. Feel free to open...