Benoit Jacob
Benoit Jacob
I was thinking vector-to-vector, rewriting `vector.interleave` to `vector.shuffle`. This way, only a single pattern is needed, not backend-specific, and by construction we know current backends are happy with `vector.shuffle` since...
no no, a file is there but it only contains an unrelated `UnrollInterleaveOp` pattern. The pattern that we need here does not exist yet, it needs to be created.
@kuhar @qedawkins , does this look like what we discussed? https://github.com/llvm/llvm-project/pull/91800 Then I'm looking on the IREE side where to put this in the SPIRV pipeline. Maybe around https://github.com/iree-org/iree/blob/a3b7e12f1ae3b4d0da9cc5dfa5fb7865b178ec4b/compiler/src/iree/compiler/Codegen/SPIRV/SPIRVInitialVectorLowering.cpp#L298-L511 ?...
> Can we put it upstream in https://github.com/llvm/llvm-project/blob/e9f53e4095d8a8600b5c5d445c73e2d5a6f45abb/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp#L812 ? I have updated the PR with that, thanks for the tip! > Nice, that looks great to me. In terms of...
So should the upstream PR do it in [VectorToSPIRV.cpp#L812](https://github.com/llvm/llvm-project/blob/e9f53e4095d8a8600b5c5d445c73e2d5a6f45abb/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp#L812) or not? If it should do that upstream, then nothing needs to be done on the IREE side, right?
but that sounds like solving a more general problem than my immediate concern of flattening our llvm integration. The upstream change that we have to carry a local revert of...
@mariecwhite, we're going to need help here! Context in the issue description above.
Watch the logs while the benchmarks run and you'll see we are definitely waiting on execution :-) While the vmfbs are shared, there is also the overhead of transferring and...
Ran the experiment at https://github.com/openxla/iree/pull/16857... found that wholesale dropping all the related code would be a -345 lines of code shrink, and found the following timings from comparing that PR...
What if we only disabled Tracy captures on PR runs?