Benoit Jacob
Benoit Jacob
> @bjacob Just stumbled on this. Capstone v5 and v4 have those macros now. See capstone.h in each branch. I'm not sure that we can count on all users' package...
The guaranteed thing that we can do here is, as suggested in the PR description, fork those CS compatibility macros on the Tracy side.
> https://github.com/wolfpld/tracy/pull/707 should solve this. From a cursory look --- it looks like this hardcodes Capstone 5.0.1 ? I actually need to use Capstone 6 to use recent ISA extensions....
Looks like a good step though, from where the capstone 5->6 move could be made as a second step ? Given the headache that capstone has been giving tracy users,...
Yup, exactly. Once https://github.com/wolfpld/tracy/pull/707 is merged, and we've rebased our downstream to work with that, i'll rebase the present PR into a capstone 5->6 bump (which you may or may...
Yup, that's the plan laid out at https://github.com/iree-org/iree/issues/16777. The above https://github.com/wolfpld/tracy/pull/671#issuecomment-2016830130 implies that the first step in the tasklist there is already completed, and what you describe doing is the...
not a strict dependence at every step, just my suggestion how in what order to tackle things.
> sorry for the delay - I looked last week but didn't think it was up to date, as we'd chatted about separating this from tracing entirely and it looks...
@benvanik : Should be good now.