diff icon indicating copy to clipboard operation
diff copied to clipboard

Fixes #24 crash when keys were removed from a map

Open cvogt opened this issue 8 years ago • 5 comments

cvogt avatar Mar 30 '17 23:03 cvogt

would be great to get this merged. We had to vendor the library and make the change ourselves because it was preventing us from using it properly.

hderms avatar Sep 25 '18 15:09 hderms

@caente if I could get back merge rights, I would do it :)

cvogt avatar Sep 25 '18 16:09 cvogt

hey sorry the delay, I was on vacation! what do you think about adding a test that replicates the issue?

caente avatar Oct 15 '18 14:10 caente

I will continue on this in https://github.com/xdotai/diff/pull/29

mirelon avatar Jun 04 '21 12:06 mirelon

I have added some tests. They were failing before the fix (this one: diff(Map("a" -> "b", "c" -> "d"),Map("a" -> "b"))). With the fix they run OK.

mirelon avatar Jun 04 '21 12:06 mirelon