SwiftyStoreKit
SwiftyStoreKit copied to clipboard
bizz84
iOS 16 (am not sure) restoring purchases hangs?
Restoring purchases hangs
I am not sure if this is AppStore issue, but today I cannot successfully call restoring purchases method. Completion handler is never called - hangs. Anyone else with this issue?
My third app still built with Xcode 13 is ok. Both my other apps built with Xcode 14 have the same issues - hangs. I guess the problem could not be with Bitcode setting No (it is not recommended anymore having Bitcode Yes on Pods)?
EDIT: More specifically, this one hangs restoreCompletedTransactions
Yes, there seems to be an issue with iOS 16 https://developer.apple.com/forums/thread/713533
Now I'm not sure if that's a bug on their side that they are going to fix or if some parameters have changed, leading to SwiftyStoreKit not recognizing the data the App Store sends
I have tried the SwiftyStoreKit demo app with Xcode 14.1 Beta 1, but the callback is not called after restoring.
Does this problem occur only in the Sandbox environment?
FYI, it’s also in Production environment. As recommended, I have refactored first of my apps to StoreKit2 with the help of Mercato git library.
I have apps that rely on SwiftyStoreKit and running directly on device and also through Testflight I can purchase and restore with no problems (testing on iPhone 11 Pro, iOS 16.0).
Could you please share more details about your test environment?
After I built my apps (no changes in the code) with Xcode Version 14.0 (14A309), pushed them to AppStore, restore purchases stoped working. I have iPhone 13 Pro (tested it directly on it)
After I built my apps (no changes in the code) with
Xcode Version 14.0 (14A309), pushed them to AppStore, restore purchases stoped working.
Does it work on Testflight?
Does it work on Testflight?
Nope. (TestFlight == production right?)
(as suggested on main repo site - I migrated to StoreKit 2 all of my apps)
Which version of SwiftyStoreKit are you using?
I'm using cocoapods: pod 'SwiftyStoreKit', '0.15.0'
Which version of SwiftyStoreKit are you using?
Always latest/updated as Swift package.
I was planning to release an updated version built with Xcode 14 but I guess I'll wait a while then
I can confirm that this is happening on iOS 16 even when build with Xcode 13.
https://zenn.dev/ch3cooh/scraps/5a907126170634 (use Google Translate to translate the page) has some more insight on this. The most important bit is that one:
I confirmed that the callback of paymentQueueController.restorePurchases was not returned.
fileprivate func restorePurchases(atomically: Bool = true, applicationUsername: String = "", completion: @escaping (RestoreResults) -> Void) {
paymentQueueController.restorePurchases(RestorePurchases(atomically: atomically, applicationUsername: applicationUsername) { results in
let results = self.processRestoreResults(results)
completion(results)
})
}
I've kind of given up on the whole SwiftyStoreKit thing but now that this person has been able to estimate a cause there may actually be some hope
@CH3COOH sorry for the tag, just found your GH - what's your status now? Did you figure out anything else regarding SwiftyStoreKit or did you drop it entirely and go fully StoreKit 2?
I investigated the success or failure of the combination of Xcode and Testflight/AppStore. I was able to restore if I used a combination of Xcode 14 and App Store. I am installing SwiftyStoreKit with Carthage.
| Xcode | iOS | source | restore | app |
|---|---|---|---|---|
| 13.4.1 | 16 | App Store | OK | MyApp P |
| 13.4.1 | 16 | App Store | OK | MyApp S |
| 13.4.1 | 16 | Testflight | NG🙅♂️ | MyApp P |
| 13.4.1 | 16 | Testflight | NG🙅♂️ | MyApp S |
| 13.4.1 | 15.7 | App Store | OK | MyApp P |
| 13.4.1 | 15.7 | App Store | OK | MyApp S |
| 13.4.1 | 15.7 | Testflight | OK | MyApp S |
| 13.4.1 | 14.8 | Testflight | OK | MyApp S |
| 14.0 | 16 | App Store | OK🙆 | MyApp F |
| 14.0 | 16 | Testflight | NG🙅♂️ | MyApp F |
| 14.0 | 16 | Testflight | NG🙅♂️ | MyApp P |
| 14.0 | 16 | Xcode Debug | NG🙅♂️ | SwiftyStoreKit demo app |
| 14.1 Beta | 16 | Xcode Debug | NG🙅♂️ | SwiftyStoreKit demo app |
@Reiszecke
This bug is that restoreCompletedTransactionsFailedWithError or paymentQueueRestoreCompletedTransactionsFinished in PaymentQueueController is not called.
https://github.com/bizz84/SwiftyStoreKit/blob/f3265c7c211907ad913102c61c3972b880f0675c/Sources/SwiftyStoreKit/PaymentQueueController.swift#L265-L271
However, we were unable to discover why the callback was not called in the case of the combination of Xcode 14 and Testflight.
I would like to fix SwiftyStoreKit, but I have no knowledge of StoreKit 1 and cannot fix it. If I can't fix it after investigating for a while, I would like to move to StoreKit 2.
I still haven't been able to reproduce this error with my apps, I just tested submitting new builds to TestFlight integrating SwiftyStoreKit from Carthage and SPM and both work fine for me too on my iPhone 11 Pro.
Maybe this problem could be related to the App Store region that you're using? My Apple ID account is Brazilian, with BRL as currency.
I'll submit one build to TestFlight review and share a link here so you can test if it is hanging on your devices
@CH3COOH thank you for the insights - we have moved to SK2 now. Testing is a real pain but hopefully everything is going to work out now. Good luck to you too!
@ArthurAlvarez It's hard for me to estimate but I'd say I don't see this problem with all devices if I consider purchases and support requests.
You can do the link-sharing and I can tell you whether it worked or not if that helps you. I will probably say bye to SSK but not because I think it's at fault - it's because I think the issue is very likely with SK1, it seems like Apple tried to touch something they shouldn't have touched for iOS 16. Otherwise it doesn't make sense why iOS 16 behaves differently than iOS 15.
What's odd is that I can hardly find any other reports. I'd guess more than 90% of the apps on the App Store are on SK1 or on a library that depends on it.
@joseph2166
I can confirm that this is happening on iOS 16 even when build with Xcode 13.
This is what I don't understand. It doesn't seem to affect everyone for some reason. Do you have bitcode enabled in your apps?
@Reiszecke Testing SK2 with Xcode 14 is quite easy using StoreKit configuration file. Check it on google.
FYI, I also disabled Bitcode on my apps as suggested by Xcode 14.
Here is the Testflight link: https://testflight.apple.com/join/kRV7inhy
In my device (iPhone 11 Pro - iOS 16.0) this build is restoring OK. Please check on your devices so we can try to determine if the problem is build-related.
Can someone also provide a Testflight link of some app that is failing to restore?
Here is the Testflight link: https://testflight.apple.com/join/kRV7inhy
In my device (iPhone 11 Pro - iOS 16.0) this build is restoring OK. Please check on your devices so we can try to determine if the problem is build-related.
Can someone also provide a Testflight link of some app that is failing to restore?
As per the screenshot feedback I just sent through TestFlight, I’m just getting a spinning green Buy button
Green button spun for 10 seconds (probably SK TF Sandbox delay)
I have first tried restoring because why not, did not work. Then I have purchased, purchase went through, was recognized. I have uninstalled, restored again, worked again.
iPhone SE 3rd gen iOS 16.
What's your dev machine setup? OS, Xcode version and bitcode enabled/disabled?
As per the screenshot feedback I just sent through TestFlight, I’m just getting a spinning green Buy button
Please wait a while for it to fetch the product. I don't know why but it is slow on TestFlight environment.
What's your dev machine setup? OS, Xcode version and bitcode enabled/disabled?
Macbook with M1 Pro processor, macOS Monterey, Xcode 14.0 (14A309), bitcode disabled
Can everyone here comment their bitcode configurations? This may actually be the issue here. Checked with another app so so far we have
| App | Bitcode? | Xcode 14? | SSK iOS 14? |
|---|---|---|---|
| Reiszecke 1 | ✅ | ❌ | ❌ |
| Reiszecke 2 | ❌ | ❌ | ✅ |
| Arthur 1 | ❌ | ✅ | ✅ |
@sabiland I'm not sure if I understood what apps of yours are bitcode and which ones aren't - can you elaborate the missing info?
| Sabi 1 | | |
| Sabi 2 | | |
| Sabi 3 | | |
So we don't have any development on this... Are you all moving away from SwiftyStoreKit or this problem just happens in Sandbox?
If I understood correctly you didn't have any issues in your non-bitcode app. I think that's the key, you don't need to do anything on your end I guess. SSK is pretty much on hold anyway.
I moved away from SSK to SK2 now because I couldn't afford messing around with build settings etc. and releasing a potentially breaking update so I have released whatever worked with TestFlight (automatic Sandbox) accounts and released that.
If I understood correctly you didn't have any issues in your non-bitcode app. I think that's the key, you don't need to do anything on your end I guess. SSK is pretty much on hold anyway.
I moved away from SSK to SK2 now because I couldn't afford messing around with build settings etc. and releasing a potentially breaking update so I have released whatever worked with TestFlight (automatic Sandbox) accounts and released that.
Just for curiosity, are you using a library that wraps SK2 or implementing it directly?
Was thinking about using https://github.com/tikhop/Mercato/issues/4 but the issue sounded too risky, so it's native SK2 without any library. RevenueCat is also fairly simple to add however if you browse through their forums, they have also messed up something in their code more than once so far so that's another risk I would only take for a temporary hotfix. In other words unless we see any issues with native SK2 it's probably the best decision to bite the bullet and move over to SK2. Testing is still an absolute nightmare tho.
About adding the code; SK2 really is much simpler than SK1 - the implementation code amount required is fairly similar to SSK. I think Apple could've made this A LOT simpler still by simply providing a singleton that has getters for each IAP identifier but I doubt there will ever be a SK3 so it probably won't get better than this, ever