selling-partner-api-sdk icon indicating copy to clipboard operation
selling-partner-api-sdk copied to clipboard
verified publisher icon bizon

[feature request] regenerate notifications schemas

Open michael-land opened this issue 2 years ago • 3 comments

B2bAnyOfferChangedNotification schema is missing

B2bAnyOfferChangedNotification.json

michael-land avatar Sep 15 '23 14:09 michael-land

Hi @michael-land

As it is often the case, the source file is broken, so the type does not generate.

https://github.com/amzn/selling-partner-api-models/blob/806b438ed95dde14ad832119cabce81a2570a3da/schemas/notifications/B2bAnyOfferChangedNotification.json#L148

This should be #/definitions/moneyType.

I’ve opened a PR – https://github.com/amzn/selling-partner-api-models/pull/332, but it’s unlikely that it’ll get any attention.

tusbar avatar Sep 17 '23 09:09 tusbar

are you ok with patches to correct those errors while waiting for the schema to be updated?

michael-land avatar Sep 17 '23 09:09 michael-land

This doesn’t fix the issue as the source schema is still broken… but I’m now generating and exposing all the JSON schemas from the source repo to @sp-api-sdk/schemas.

https://github.com/bizon/selling-partner-api-sdk/pull/1316

tusbar avatar Sep 20 '24 08:09 tusbar