bitwhip icon indicating copy to clipboard operation
bitwhip copied to clipboard

Feature: Enable HighDPI in SDL Window for OSX Retina

Open ash30 opened this issue 5 months ago • 4 comments

This is a simple implementation:

  • Checks pixel scaling via NSScreen bindings once at startup
  • it doesn't currently react to changing displays

I'm not aware if this functionality is useful to other platforms? So I've left it under platform config for now

ash30 avatar Jul 31 '25 21:07 ash30

I think use objc2::MainThreadMarker; in player.rs is preventing me from compiling your branch on linux. image

I'm not too familiar with Rust, so I'm not sure what the fix would be for this. but this is the next error after trying to add a #[cfg(target_os = "macos")] to the objc2 crate.

image

ghost avatar Aug 14 '25 00:08 ghost

Thanks for the feedback @BigLugiaFollower ! User error on my part 😅 , pushed a small fix .

ash30 avatar Aug 14 '25 20:08 ash30

Haven't touched bit whip for a bit but on a random cool news front, I've now added a linux hosted CI CD action on my fork , so in future can ensure linux compatibility

https://github.com/ash30/bitwhip/actions/runs/17428070278/job/49479732324

ash30 avatar Sep 03 '25 08:09 ash30

That's awesome!

After you made that fix, I had encountered more issues trying to get your fork to compile, but I didn't want to spam the thread until I understood what the error meant more. :P

ghost avatar Sep 06 '25 19:09 ghost