server icon indicating copy to clipboard operation
server copied to clipboard

[PM-28485] Move organization events domain to DIRT code ownership

Open eliykat opened this issue 1 month ago â€ĸ 4 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-28485

📔 Objective

Move code relating to organization events into DIRT code ownership.

Intentionally excluded:

  • Secrets Manager event code - owned by SM Team (this is a bit incongruous but I'll leave it to DIRT as to whether they want to follow this up)
  • the events integration infrastructure - this will be moved by the architecture team who developed this.

Namespaces have generally not been updated in order to minimize impact through the codebase.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

eliykat avatar Dec 04 '25 00:12 eliykat

Claude finished @eliykat's task in 2m 51s —— View job


Code Review Complete

  • [x] Starting review of PR #6685
  • [x] Analyzing code changes
  • [x] Posting review comments

Review completed. The bitwarden-code-reviewer agent has posted its findings directly to the PR.

claude[bot] avatar Dec 04 '25 00:12 claude[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.54%. Comparing base (e6c97bd) to head (699ebcb). :warning: Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6685      +/-   ##
==========================================
+ Coverage   54.71%   58.54%   +3.82%     
==========================================
  Files        1925     1925              
  Lines       85671    85671              
  Branches     7670     7670              
==========================================
+ Hits        46876    50155    +3279     
+ Misses      37011    33658    -3353     
- Partials     1784     1858      +74     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 04 '25 00:12 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – c91763e1-30bc-4013-8b59-48b87203286d

Great job! No new security vulnerabilities introduced in this pull request

github-actions[bot] avatar Dec 04 '25 01:12 github-actions[bot]

We have some larger changes still coming in with our caching work so looking at this right now gives me some pause.

withinfocus avatar Dec 04 '25 15:12 withinfocus

@eliykat Do you mind fixing the merge conflict?

prograhamming avatar Dec 18 '25 19:12 prograhamming