server
server copied to clipboard
[SM-1743] feature flag implementation for disableSMAdsForUsers
đī¸ Tracking
https://bitwarden.atlassian.net/jira/software/c/projects/SM/boards/74?assignee=625cb516fd06270069beaf5d&selectedIssue=SM-1743
đ Objective
feature flag implementation for disableSMAdsForUsers
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â db02719c-ee45-4780-96dd-e7bace5a83d7
Great job! No new security vulnerabilities introduced in this pull request
Codecov Report
:x: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.01%. Comparing base (196e555) to head (7f88b98).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6614 +/- ##
==========================================
+ Coverage 54.10% 58.01% +3.90%
==========================================
Files 1922 1922
Lines 85153 85086 -67
Branches 7608 7606 -2
==========================================
+ Hits 46073 49361 +3288
+ Misses 37325 33897 -3428
- Partials 1755 1828 +73
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.