server icon indicating copy to clipboard operation
server copied to clipboard

[SM-1743] feature flag implementation for disableSMAdsForUsers

Open cd-bitwarden opened this issue 1 month ago â€ĸ 1 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/jira/software/c/projects/SM/boards/74?assignee=625cb516fd06270069beaf5d&selectedIssue=SM-1743

📔 Objective

feature flag implementation for disableSMAdsForUsers

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cd-bitwarden avatar Nov 20 '25 22:11 cd-bitwarden

Logo Checkmarx One – Scan Summary & Details – db02719c-ee45-4780-96dd-e7bace5a83d7

Great job! No new security vulnerabilities introduced in this pull request

github-actions[bot] avatar Nov 20 '25 22:11 github-actions[bot]

Codecov Report

:x: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.01%. Comparing base (196e555) to head (7f88b98). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...illing/Organizations/Models/OrganizationLicense.cs 40.00% 3 Missing :warning:
...Admin/AdminConsole/Models/OrganizationEditModel.cs 33.33% 2 Missing :warning:
...mplementations/OrganizationLicenseClaimsFactory.cs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6614      +/-   ##
==========================================
+ Coverage   54.10%   58.01%   +3.90%     
==========================================
  Files        1922     1922              
  Lines       85153    85086      -67     
  Branches     7608     7606       -2     
==========================================
+ Hits        46073    49361    +3288     
+ Misses      37325    33897    -3428     
- Partials     1755     1828      +73     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 12 '25 21:12 codecov[bot]