[SM-1570] Adding new item to organization license to disable SM ads for users
đī¸ Tracking
https://bitwarden.atlassian.net/browse/SM-1740 https://bitwarden.atlassian.net/browse/SM-1742
đ Objective
Adding the new column to the database for adding a new item to the organization table for "disabling SM ads for users", this new item is called UseDisableSMAdsForUsers.
- SQL updates to the Organization table
- Migration Scripts
- Entity Framework Changes
- Followed advice from Connor Turnbull and these documents : https://bitwarden.atlassian.net/wiki/spaces/EN/pages/2014642217/Adding+a+new+plan+feature, https://bitwarden.atlassian.net/wiki/spaces/EN/pages/2070446163/Technical+Breakdown+Disable+SM+Ads+for+Users
đ¸ Screenshots
N/A
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 358ff6c0-ef67-4917-aefa-cceff69af618
Great job! No new security vulnerabilities introduced in this pull request
Codecov Report
:x: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.55%. Comparing base (e6c97bd) to head (2c1701d).
Additional details and impacted files
@@ Coverage Diff @@
## main #6482 +/- ##
==========================================
+ Coverage 54.71% 58.55% +3.84%
==========================================
Files 1925 1925
Lines 85671 85698 +27
Branches 7670 7670
==========================================
+ Hits 46876 50182 +3306
+ Misses 37011 33657 -3354
- Partials 1784 1859 +75
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Claude finished @cd-bitwarden's task in 2m 51s ââ View job
Code Review Complete
- [x] Starting code review
- [x] Analyzing changes
- [x] Posting review comments
The bitwarden-code-reviewer agent has completed its review and posted inline comments directly on the PR.
Overall Assessment: REQUEST CHANGES
Critical Issues:
- src/Core/AdminConsole/Services/OrganizationFactory.cs:119 - Missing UseDisableSmAdsForUsers in obsolete license path
- util/Migrator/DbScripts/2025-12-18_00_AddDisableSMAdsForUsersToOrganization.sql:1 - Future-dated migration script filename
See inline comments for details.