[PM-18239] Master password policy requirement
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-18239
đ Objective
Implement policy requirement for the Master Password policy.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Should this policy requirement also be used in PoliciesController.cs? (specifically on the master-password Get endpoint) @eliykat
Checkmarx One â Scan Summary & Details â 1cdfd68f-a9b5-4d16-a326-a32dfc470596
Great job, no security vulnerabilities found in this Pull Request
Codecov Report
Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.
Project coverage is 48.46%. Comparing base (
828003f) to head (6478584). Report is 24 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5936 +/- ##
==========================================
+ Coverage 48.08% 48.46% +0.37%
==========================================
Files 1731 1735 +4
Lines 76425 77034 +609
Branches 6824 6876 +52
==========================================
+ Hits 36746 37331 +585
+ Misses 38198 38193 -5
- Partials 1481 1510 +29
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Auth Team no longer need back-end changes so I'll have another look at this next week.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code