server icon indicating copy to clipboard operation
server copied to clipboard

[PM-18239] Master password policy requirement

Open BTreston opened this issue 7 months ago â€ĸ 4 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-18239

📔 Objective

Implement policy requirement for the Master Password policy.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

BTreston avatar Jun 06 '25 20:06 BTreston

Should this policy requirement also be used in PoliciesController.cs? (specifically on the master-password Get endpoint) @eliykat

BTreston avatar Jun 06 '25 20:06 BTreston

Logo Checkmarx One – Scan Summary & Details – 1cdfd68f-a9b5-4d16-a326-a32dfc470596

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar Jun 06 '25 20:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Project coverage is 48.46%. Comparing base (828003f) to head (6478584). Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...icyRequirements/MasterPasswordPolicyRequirement.cs 76.00% 6 Missing :warning:
...nConsole/Services/Implementations/PolicyService.cs 75.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5936      +/-   ##
==========================================
+ Coverage   48.08%   48.46%   +0.37%     
==========================================
  Files        1731     1735       +4     
  Lines       76425    77034     +609     
  Branches     6824     6876      +52     
==========================================
+ Hits        36746    37331     +585     
+ Misses      38198    38193       -5     
- Partials     1481     1510      +29     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 09 '25 16:06 codecov[bot]

Auth Team no longer need back-end changes so I'll have another look at this next week.

eliykat avatar Jun 20 '25 04:06 eliykat