server icon indicating copy to clipboard operation
server copied to clipboard

Auth/pm 18720/change password component non dialog

Open Patrick-Pimentel-Bitwarden opened this issue 7 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Logo Checkmarx One – Scan Summary & Details – 474e1257-3c96-44c0-9bfe-053e024452cd

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM ~~CSRF~~ /src/Api/AdminConsole/Controllers/GroupsController.cs: 164

github-actions[bot] avatar Jun 06 '25 00:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.74%. Comparing base (63f5811) to head (c74428f). Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...sers/InviteUsers/SendOrganizationInvitesCommand.cs 50.00% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5928      +/-   ##
==========================================
+ Coverage   47.54%   47.74%   +0.19%     
==========================================
  Files        1669     1665       -4     
  Lines       75348    75014     -334     
  Branches     6760     6757       -3     
==========================================
- Hits        35826    35817       -9     
+ Misses      38063    37735     -328     
- Partials     1459     1462       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 06 '25 00:06 codecov[bot]