[PM-21918] update send api models to support new `email` field
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-21918
Implements #5895
đ Objective
Update send API models to support email/OTP administration.
[!IMPORTANT] This PR includes documentation for the related models. I mostly inferred what each of these are. Please focus on them during review to confirm that the comments are correct.
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
đ This PR may wait to merge until the CLI logic is stable.
Checkmarx One â Scan Summary & Details â 38cebc47-7ea2-4eef-b8b5-7179bcfeee26
New Issues (3)
Checkmarx found the following issues in this Pull Request
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 419 | detailsMethod at line 419 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow...ID: XWl46lV2X%2BBt49nNe5GE3VUr%2Fy0%3D |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1508 | detailsMethod at line 1508 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...ID: Tk%2FmvJPGUHNjl6cjrFHos7YAa1M%3D |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1389 | detailsMethod at line 1389 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...ID: KKbwt1aUy7U49Pl7Stx2veFr%2FSU%3D |
Fixed Issues (3)
Great job! The following issues were fixed in this Pull Request
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
~~CSRF~~ | /src/Api/Controllers/CollectionsController.cs: 176 |
![]() |
~~CSRF~~ | /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 97 |
![]() |
~~CSRF~~ | /src/Api/Vault/Controllers/CiphersController.cs: 299 |
Codecov Report
:x: Patch coverage is 74.07407% with 14 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.43%. Comparing base (236027f) to head (fb27708).
:warning: Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5895 +/- ##
==========================================
+ Coverage 49.27% 49.43% +0.15%
==========================================
Files 1770 1778 +8
Lines 78536 78724 +188
Branches 6993 7009 +16
==========================================
+ Hits 38696 38914 +218
+ Misses 38323 38288 -35
- Partials 1517 1522 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Moving this back to draft because the server requirements have changed.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
