server icon indicating copy to clipboard operation
server copied to clipboard
verified publisher icon bitwarden

[deps]: Update Microsoft.NET.Test.Sdk to 17.14.1

Open renovate[bot] opened this issue 8 months ago • 2 comments

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
Microsoft.NET.Test.Sdk 17.12.0 -> 17.14.1 age adoption passing confidence
Microsoft.NET.Test.Sdk 17.8.0 -> 17.14.1 age adoption passing confidence

Release Notes

microsoft/vstest (Microsoft.NET.Test.Sdk)

v17.14.1

What's Changed

Full Changelog: https://github.com/microsoft/vstest/compare/v17.14.0...v17.14.1

v17.14.0

What's Changed

.NET versions updated

This version of VS Test upgraded .NET to net8 and net9. All projects targeting net6.0 (or other end-of-life .NET target frameworks) should pin their version of Microsoft.NET.Test.SDK to 17.13.0, or update the projects to net8 or newer. We remain backwards compatible with previous versions of Microsoft.NET.Test.SDK. This change does NOT prevent you from:

  • Updating to the latest VS, and running tests from net6.0 test projects.
  • Updating to the latest .NET SDK, and running tests from net6.0 test projects.

It also has no impact on .NET Framework projects, where we continue targeting .NET Framework 4.6.2.

Changes
Internal version updates and fixes

New Contributors

Full Changelog: https://github.com/microsoft/vstest/compare/v17.13.0...v17.14.0

v17.13.0

What's Changed

New Contributors

Full Changelog: https://github.com/microsoft/vstest/compare/v17.12.0...v17.13.0

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Apr 28 '25 00:04 renovate[bot]

Internal tracking:

  • ID: PM-20786
  • Link: https://bitwarden.atlassian.net/browse/PM-20786

bitwarden-bot avatar Apr 28 '25 00:04 bitwarden-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.10%. Comparing base (75d8250) to head (b2333c8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5738   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files        1913     1913           
  Lines       85280    85280           
  Branches     7635     7635           
=======================================
  Hits        45289    45289           
  Misses      38232    38232           
  Partials     1759     1759

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 28 '25 01:04 codecov[bot]

Claude finished @renovate[bot]'s task —— View job

Code Review Complete

Summary

This PR updates Microsoft.NET.Test.Sdk from 17.8.0 and 17.12.0 to 17.14.1 in two test projects. However, this creates version inconsistency across the solution, as most test projects use a centrally managed version.

Critical Issues

Finding 1: ❌ Inconsistent version management - two projects bypass central version control

The two changed files hardcode version 17.14.1, while Directory.Build.props:19 defines MicrosoftNetTestSdkVersion=17.8.0 that 20 other test projects use. This creates maintenance burden and version drift.

Affected projects

Hardcoded versions (2 projects):

  • test/Core.IntegrationTest/Core.IntegrationTest.csproj:15
  • test/Infrastructure.Dapper.Test/Infrastructure.Dapper.Test.csproj:11

Central version (20 projects): All other test projects reference $(MicrosoftNetTestSdkVersion) from Directory.Build.props

Finding 2: ⚠️ Missing breaking change assessment for v17.14.0

Release notes indicate v17.14.0 dropped support for end-of-life frameworks (net6.0) and now targets net8/net9. While both changed projects target net8.0, the PR description lacks assessment of compatibility implications.

Release notes excerpt

All projects targeting net6.0 (or other end-of-life .NET target frameworks) should pin their version of Microsoft.NET.Test.SDK to 17.13.0, or update the projects to net8 or newer.

Both projects already target net8.0, so this change is compatible. However, this should be explicitly validated in the PR description.

Finding 3: 💭 Why were only these two projects updated?

The PR updates 2 of 22 test projects. Is there a specific reason these two deviated from the central version, or should all projects be updated together?

Suggested Improvements

Finding 4: ♻️ Should update central version instead of individual projects

To maintain version consistency and simplify dependency management, consider updating MicrosoftNetTestSdkVersion in Directory.Build.props to 17.14.1, which would automatically propagate to all 20 projects using the variable.

Recommended approach
  1. Update Directory.Build.props:19 from 17.8.0 to 17.14.1
  2. Change both modified .csproj files to use Version="$(MicrosoftNetTestSdkVersion)" instead of hardcoded 17.14.1
  3. This ensures all 22 test projects use the same version

If these two projects need a different version for specific reasons, document why in comments.

Good Practices Observed

  • Both projects already target net8.0, making them compatible with the new test SDK version

PR Title and Description Quality

Finding 5: 💭 PR description lacks compatibility validation

While the PR includes comprehensive release notes, it doesn't explicitly validate that the breaking changes in v17.14.0 don't affect this codebase. Adding a brief compatibility statement would improve confidence in the update.

Action Items

  1. Address version inconsistency (Finding 1) - either update central version or document why these projects differ
  2. Validate and document compatibility with v17.14.0 breaking changes (Finding 2)
  3. Clarify why only 2 of 22 projects were updated (Finding 3)

claude[bot] avatar Nov 20 '25 12:11 claude[bot]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Nov 20 '25 12:11 renovate[bot]

Logo Checkmarx One – Scan Summary & Details – 22d40363-ad07-4863-8b5b-36fcbf00884e

Great job! No new security vulnerabilities introduced in this pull request

github-actions[bot] avatar Nov 20 '25 12:11 github-actions[bot]

Superseded by https://github.com/bitwarden/server/pull/6449

djsmith85 avatar Dec 09 '25 13:12 djsmith85

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

renovate[bot] avatar Dec 09 '25 13:12 renovate[bot]