server Innovation/archive/server

🎟️ Tracking

Innovation Sprint Server Work

📔 Objective

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

Apr 18 '25 19:04 Patrick-Pimentel-Bitwarden

LaunchDarkly flag references

:mag: 1 flag added or modified

Name	Key	Aliases found	Info
Innovation Sprint - Archive Items	`pm-19148-innovation-archive`

Apr 18 '25 19:04 github-actions[bot]

Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
52.5% Duplication on New Code

See analysis details on SonarQube Cloud

Apr 18 '25 19:04 sonarqubecloud[bot]

Codecov Report

:x: Patch coverage is 53.88601% with 89 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.18%. Comparing base (aab50ef) to head (f93081f). :warning: Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Api/Vault/Controllers/CiphersController.cs	8.69%	42 Missing :warning:
...tyFramework/Vault/Repositories/CipherRepository.cs	67.39%	12 Missing and 3 partials :warning:
...ture.Dapper/Vault/Repositories/CipherRepository.cs	47.36%	10 Missing :warning:
src/Core/Vault/Commands/UnarchiveCiphersCommand.cs	70.96%	6 Missing and 3 partials :warning:
src/Core/Vault/Commands/ArchiveCiphersCommand.cs	80.00%	3 Missing and 3 partials :warning:
...re/Vault/Services/Implementations/CipherService.cs	0.00%	4 Missing and 1 partial :warning:
src/Api/Vault/Models/Request/CipherRequestModel.cs	50.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5672      +/-   ##
==========================================
+ Coverage   49.86%   54.18%   +4.32%     
==========================================
  Files        1824     1826       +2     
  Lines       80917    81080     +163     
  Branches     7180     7198      +18     
==========================================
+ Hits        40346    43935    +3589     
+ Misses      39015    35508    -3507     
- Partials     1556     1637      +81

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

:snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
:package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Apr 18 '25 19:04 codecov[bot]

Checkmarx One – Scan Summary & Details – ffdd6687-ffee-4235-9f23-3877928f0d44

New Issues (4)

Checkmarx found the following issues in this Pull Request

Issue	Source File / Package	Checkmarx Insight
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1303	details Method at line 1303 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... `ID: BWZ6MSm0d7zAXgXbKpeZ3Y33fNk%3D` Attack Vector
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1423	details Method at line 1423 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... `ID: bRQ6kgGAVFcT5beY1oJm%2FHaFmCg%3D` Attack Vector
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1328	details Method at line 1328 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... `ID: yYQSxASiu37MwK3D3WkWP%2FGHW6U%3D` Attack Vector
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1355	details Method at line 1355 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... `ID: nu8nCsd1Ie%2BmDXBYHM0CWTv6Jog%3D` Attack Vector

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	~~CSRF~~	/src/Api/Vault/Controllers/CiphersController.cs: 1334
	~~CSRF~~	/src/Api/Vault/Controllers/CiphersController.cs: 1266
	~~CSRF~~	/src/Api/Vault/Controllers/CiphersController.cs: 1239
	~~CSRF~~	/src/Api/Vault/Controllers/CiphersController.cs: 1214