[PM-14188] Option to disable built in mssql container
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-14188
đ Objective
Add a configuration value to allow toggling the built-in MSSQL container image. The container should be enabled by default, but enable_built_in_ms_sql can be set to false for users with external databases configured.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 47.72%. Comparing base (
71aae24) to head (c866f42).
Additional details and impacted files
@@ Coverage Diff @@
## main #4954 +/- ##
=======================================
Coverage 47.72% 47.72%
=======================================
Files 1692 1692
Lines 74972 74972
Branches 6758 6758
=======================================
Hits 35777 35777
Misses 37739 37739
Partials 1456 1456
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Ephemeral Environment Details: Web: https://option-to-disable-built-in-mssql.ee.bitwarden.pw/web Api: https://option-to-disable-built-in-mssql.ee.bitwarden.pw/api
@tangowithfoxtrot is this still needed?
@addisonbeck I likely won't be switching back to this any time soon đ It can be closed if you're pruning tasks for Platform.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Checkmarx One â Scan Summary & Details â 2c65786f-7232-40c0-b9e5-9819e49dfb82
New Issues (1)
Checkmarx found the following issues in this Pull Request
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 164 | detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter v...ID: yt2PajNvte2IY7Xe%2FRtOPf8qKlo%3D |
