server
server copied to clipboard
[PM-10703] Admin Portal Selecting Families plan does not check defau…
…lt features
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10703
📔 Objective
Families plan is not checking default features when being selected.
This is happening because the families plan doesn't support secrets manager when a free or paid organization has secrets manager selected. Because it then resolved to an undefined plan, no values are being selected. So we remove the filter in the OrganizationEditModel
.
To get the error message to display properly, we store the error message in TempData
and then redirect to the Edit
action.
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:
) or similar for great changes - 📝 (
:memo:
) or ℹ️ (:information_source:
) for notes or general info - ❓ (
:question:
) for questions - 🤔 (
:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:
) for suggestions / improvements - ❌ (
:x:
) or ⚠️ (:warning:
) for more significant problems or concerns needing attention - 🌱 (
:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt - ⛏ (
:pick:
) for minor or nitpick changes