server icon indicating copy to clipboard operation
server copied to clipboard

[PM-10563] Notification Center API

Open mzieniukbw opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-10563

📔 Objective

Notification API:

  • List notifications for user.
    • Optional pagination by continuation token and page size, including validation.
    • Updated Dapper, EF and Sql migrations.
  • Mark notification as read and deleted
    • fixed bug, where incorrect date time was populated in MarkNotificationDeletedCommand and MarkNotificationReadCommand during create operation - now UTC format

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

mzieniukbw avatar Oct 04 '24 13:10 mzieniukbw

Codecov Report

Attention: Patch coverage is 84.03361% with 19 lines in your changes missing coverage. Please review.

Project coverage is 43.39%. Comparing base (de2dc24) to head (ba8c06c). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ationCenter/Repositories/NotificationRepository.cs 0.00% 19 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4852      +/-   ##
==========================================
+ Coverage   43.15%   43.39%   +0.23%     
==========================================
  Files        1452     1456       +4     
  Lines       66301    66412     +111     
  Branches     6073     6078       +5     
==========================================
+ Hits        28615    28817     +202     
+ Misses      36398    36304      -94     
- Partials     1288     1291       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 13:10 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – c7e1bb3d-990b-45ad-a4d3-d0fbf269d7a1

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 241 Attack Vector
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 67 Attack Vector
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 61 Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 406 Attack Vector

github-actions[bot] avatar Oct 04 '24 14:10 github-actions[bot]

The change is ready to be picked up by QA. @Thomas-Avery @withinfocus @rkac-bw Updating PR with newest main to the branch. Renamed the db migration script date (file name change) to today's. No other changes, please approve.

mzieniukbw avatar Nov 19 '24 19:11 mzieniukbw

Ready to be merged. Updated the database migration script date to today.

mzieniukbw avatar Dec 18 '24 13:12 mzieniukbw