Return Non-Zero Exit Code On Failure

[justindbaur]

🎟️ Tracking

📔 Objective

Return a non-zero exit code on failure so that github actions will mark a step that calls this project a failure if migrations could not be applied.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.74%. Comparing base (fd8c1aa) to head (bac6b5f). Report is 37 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4842      +/-   ##
==========================================
- Coverage   41.78%   41.74%   -0.04%     
==========================================
  Files        1308     1326      +18     
  Lines       62101    63015     +914     
  Branches     5720     5806      +86     
==========================================
+ Hits        25946    26306     +360     
- Misses      34960    35489     +529     
- Partials     1195     1220      +25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – 0c0efd7d-014e-4c33-aecc-6abfc5146be3

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 551
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164

[justindbaur]

Can we check all the related callsites to ensure we're covered here?

@withinfocus Like all the stuff that calls this CLI utility?

I was able to find that it's also called here, it might also be susceptible to it returning 0 on failure and it could continue. @michalchecinski Do you think that's an okay behavioral change? Hopefully the testing we do would make it pretty hard for it to return non-0 once its made its way to the release pipeline.

[withinfocus]

Can we check all the related callsites to ensure we're covered here?

@withinfocus Like all the stuff that calls this CLI utility?

Yep, just want to make sure this goes all the way up to the places it's used like our CI and release deployments, plus self-host usages.