server icon indicating copy to clipboard operation
server copied to clipboard

[SM-10995] Removing vault bulk access feature flag

Open cd-bitwarden opened this issue 1 year ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

📔 Objective

Remove server side code that sets the Vault Bulk Action feature flag.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cd-bitwarden avatar Aug 29 '24 21:08 cd-bitwarden

LaunchDarkly flag references

:x: 1 flag removed

Name Key Aliases found Info
vault-bulk-management-action vault-bulk-management-action :white_check_mark: all references removed

github-actions[bot] avatar Aug 29 '24 21:08 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.79%. Comparing base (080057c) to head (e969d45).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4713   +/-   ##
=======================================
  Coverage   41.79%   41.79%           
=======================================
  Files        1308     1308           
  Lines       62129    62129           
  Branches     5725     5725           
=======================================
  Hits        25968    25968           
  Misses      34961    34961           
  Partials     1200     1200           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 21:08 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 4512578e-ce89-43e5-8964-3e519009f94a

No New Or Fixed Issues Found

github-actions[bot] avatar Aug 29 '24 21:08 github-actions[bot]