km/pm-11240/actionable-insights-reports-backend

[mzieniukbw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11240

📔 Objective

Actionable Insight's backend for Report table part 1:

• Feature flag
• Report entity and repository
• Dapper and EF repository implementations - part of bitwarden license
• Migration scripts - EF were auto generated (MySql, PostgreSql, SqlLite)

In part 2: Services and Controllers In part 3: Test coverage

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 9.61538% with 47 lines in your changes missing coverage. Please review.

Project coverage is 41.90%. Comparing base (abc5d81) to head (b4eef5f). Report is 171 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Core/ActionableInsights/Entities/Report.cs	0.00%	17 Missing :warning:
...ctionableInsights/Repositories/ReportRepository.cs	0.00%	12 Missing :warning:
...ctionableInsights/Repositories/ReportRepository.cs	0.00%	9 Missing :warning:
...per/CommercialDapperServiceCollectionExtensions.cs	0.00%	3 Missing :warning:
...ableInsights/Models/ApplicationReportParameters.cs	0.00%	2 Missing :warning:
.../ActionableInsights/Models/UrisReportParameters.cs	0.00%	2 Missing :warning:
...Core/ActionableInsights/Models/ReportParameters.cs	0.00%	1 Missing :warning:
...SharedWeb/Utilities/ServiceCollectionExtensions.cs	50.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4687      +/-   ##
==========================================
- Coverage   41.92%   41.90%   -0.03%     
==========================================
  Files        1287     1295       +8     
  Lines       60955    61007      +52     
  Branches     5604     5606       +2     
==========================================
+ Hits        25557    25562       +5     
- Misses      34205    34252      +47     
  Partials     1193     1193              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – e67874b1-d488-438f-a29f-4b339053ca0a

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 547
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 504
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 529
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 471
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 177
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 279
	CSRF	/src/Api/Billing/Public/Controllers/OrganizationController.cs: 47
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 561