server icon indicating copy to clipboard operation
server copied to clipboard

[PM-10418] Create feature flag to toggle refactor for generation of card autofill scripts

Open cagonzalezcs opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-10418

📔 Objective

This PR creates a feature flag that will allow us to toggle between the current method used for generating an autofill script for card ciphers, and a refactored implementation to address issues detailed in PM-10418.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cagonzalezcs avatar Aug 05 '24 19:08 cagonzalezcs

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.51%. Comparing base (4d3c1c5) to head (0b8fddb). Report is 102 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4591   +/-   ##
=======================================
  Coverage   41.51%   41.51%           
=======================================
  Files        1280     1280           
  Lines       60497    60497           
  Branches     5557     5557           
=======================================
  Hits        25117    25117           
  Misses      34202    34202           
  Partials     1178     1178           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 05 '24 19:08 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 4a2390c5-d87b-415e-9bef-abc66d06b681

No New Or Fixed Issues Found

github-actions[bot] avatar Aug 05 '24 19:08 github-actions[bot]

closing as handled in https://github.com/bitwarden/clients/pull/10705

jprusik avatar Sep 04 '24 15:09 jprusik