server icon indicating copy to clipboard operation
server copied to clipboard

SM-1146: Secrets Manager total counts

Open mzieniukbw opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/SM-1146

📔 Objective

Display total counts of projects, secrets, machine accounts.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

mzieniukbw avatar Jun 18 '24 18:06 mzieniukbw

Codecov Report

Attention: Patch coverage is 84.32432% with 29 lines in your changes missing coverage. Please review.

Project coverage is 41.75%. Comparing base (452646b) to head (120a2c3).

Files Patch % Lines
...k/SecretsManager/Repositories/ProjectRepository.cs 84.61% 3 Missing and 3 partials :warning:
...Manager/Repositories/Noop/NoopProjectRepository.cs 0.00% 6 Missing :warning:
.../Repositories/Noop/NoopServiceAccountRepository.cs 0.00% 6 Missing :warning:
...tsManager/Repositories/ServiceAccountRepository.cs 87.09% 2 Missing and 2 partials :warning:
...sManager/Repositories/Noop/NoopSecretRepository.cs 0.00% 3 Missing :warning:
...rk/SecretsManager/Repositories/SecretRepository.cs 83.33% 1 Missing and 1 partial :warning:
...yFramework/SecretsManager/Models/ServiceAccount.cs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4200      +/-   ##
==========================================
+ Coverage   41.51%   41.75%   +0.24%     
==========================================
  Files        1280     1286       +6     
  Lines       60470    60655     +185     
  Branches     5554     5566      +12     
==========================================
+ Hits        25103    25329     +226     
+ Misses      34190    34144      -46     
- Partials     1177     1182       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 18 '24 18:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 13b36bb2-8f9f-485b-951f-dda8e1d137ae

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/SecretsManager/Controllers/CountsController.cs: 37 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 147 Attack Vector
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 840 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/Billing/TrialInitiationVerifyEmail.html.hbs: 17 Attack Vector
LOW Open_Redirect /src/Admin/Auth/Controllers/LoginController.cs: 50 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 87
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 621
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 600
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 621
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 600
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 170
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 155
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 140
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 217
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1029
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1029
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 826
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 763
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 189
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1132
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1055
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1055
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 840
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1078
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1078
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 217
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 945
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1112
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 189
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 801
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 737
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 577
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 158
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 850

github-actions[bot] avatar Jun 18 '24 19:06 github-actions[bot]

@Thomas-Avery I have pushed one more commit https://github.com/bitwarden/server/pull/4200/commits/856c340e4dc4d2dd2feaac423a71f63660fdc6cf I have realised that we do not show counts for people and service accounts within the project details page, when the user is accessing the project with just read only access.

mzieniukbw avatar Jul 05 '24 23:07 mzieniukbw