SM-1146: Secrets Manager total counts
đī¸ Tracking
https://bitwarden.atlassian.net/browse/SM-1146
đ Objective
Display total counts of projects, secrets, machine accounts.
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
Attention: Patch coverage is 84.32432% with 29 lines in your changes missing coverage. Please review.
Project coverage is 41.75%. Comparing base (
452646b) to head (120a2c3).
Additional details and impacted files
@@ Coverage Diff @@
## main #4200 +/- ##
==========================================
+ Coverage 41.51% 41.75% +0.24%
==========================================
Files 1280 1286 +6
Lines 60470 60655 +185
Branches 5554 5566 +12
==========================================
+ Hits 25103 25329 +226
+ Misses 34190 34144 -46
- Partials 1177 1182 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â 13b36bb2-8f9f-485b-951f-dda8e1d137ae
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
CSRF | /src/Api/SecretsManager/Controllers/CountsController.cs: 37 | Attack Vector |
![]() |
Privacy_Violation | /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 147 | Attack Vector |
![]() |
Privacy_Violation | /src/Core/Services/Implementations/UserService.cs: 840 | Attack Vector |
![]() |
Missing_CSP_Header | /src/Core/MailTemplates/Handlebars/Billing/TrialInitiationVerifyEmail.html.hbs: 17 | Attack Vector |
![]() |
Open_Redirect | /src/Admin/Auth/Controllers/LoginController.cs: 50 | Attack Vector |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
CSRF | /src/Api/Public/Controllers/CollectionsController.cs: 87 |
![]() |
CSRF | /src/Api/Controllers/CollectionsController.cs: 143 |
![]() |
CSRF | /src/Api/Controllers/CollectionsController.cs: 171 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 621 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 600 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 621 |
![]() |
CSRF | /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 600 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 170 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 155 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 140 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 217 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1029 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1029 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 826 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 763 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 189 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1132 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1055 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1055 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 840 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1078 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1078 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 217 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 945 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1112 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 189 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 801 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 737 |
![]() |
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 577 |
![]() |
Privacy_Violation | /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 158 |
![]() |
Privacy_Violation | /src/Core/Services/Implementations/UserService.cs: 850 |
@Thomas-Avery I have pushed one more commit https://github.com/bitwarden/server/pull/4200/commits/856c340e4dc4d2dd2feaac423a71f63660fdc6cf I have realised that we do not show counts for people and service accounts within the project details page, when the user is accessing the project with just read only access.

