server
server copied to clipboard
Published
20 hours ago •
bitwarden
bitwarden
[SM-910] Add service account granted policies management endpoints
Type of change
- [ ] Bug fix
- [ X ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
The purpose of this change is to add new service account granted access policy management endpoints to support the new client design.
Code changes
- file.ext: Description of what was changed and why
Before you submit
- Please check for formatting errors (
dotnet format --verify-no-changes) (required) - If making database changes - make sure you also update Entity Framework queries and/or migrations
- Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
Codecov Report
Attention: Patch coverage is 94.98681% with 19 lines in your changes are missing coverage. Please review.
Project coverage is 38.60%. Comparing base (
a14646e) to head (9a104c4).
Additional details and impacted files
@@ Coverage Diff @@
## main #3736 +/- ##
==========================================
+ Coverage 38.30% 38.60% +0.30%
==========================================
Files 1195 1206 +11
Lines 58223 58525 +302
Branches 5583 5605 +22
==========================================
+ Hits 22302 22594 +292
- Misses 34871 34877 +6
- Partials 1050 1054 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Checkmarx One – Scan Summary & Details – 4d8905d8-6269-4680-9d74-b38e90ed2969
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
 |
CSRF | /src/Api/Controllers/CollectionsController.cs: 270 | Attack Vector |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 212 | Attack Vector |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 212 | Attack Vector |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 270 | Attack Vector |
|
Privacy_Violation | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 703 | Attack Vector |
|
Privacy_Violation | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 650 | Attack Vector |
 |
Log_Forging | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 678 | Attack Vector |
|
Log_Forging | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 615 | Attack Vector |
|
Missing_CSP_Header | /src/Core/MailTemplates/Handlebars/OrganizationSmServiceAccountsMaxReached.html.hbs: 9 | Attack Vector |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 587 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 587 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 587 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 587 |
|
CSRF | /src/Api/AdminConsole/Controllers/ProvidersController.cs: 141 |
|
CSRF | /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 309 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 145 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 145 |
|
CSRF | /src/Api/Billing/Controllers/ProviderClientsController.cs: 30 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 190 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 331 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 331 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 678 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 702 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 891 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 173 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 744 |
|
CSRF | /src/Api/Vault/Controllers/FoldersController.cs: 45 |
|
CSRF | /src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 51 |
|
CSRF | /src/Api/Controllers/UsersController.cs: 22 |
|
CSRF | /src/Api/Controllers/DevicesController.cs: 70 |
|
CSRF | /src/Api/Controllers/DevicesController.cs: 57 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 69 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 49 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 92 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 49 |
|
CSRF | /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 142 |
|
CSRF | /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 52 |
|
CSRF | /src/Api/AdminConsole/Controllers/PoliciesController.cs: 148 |
|
CSRF | /src/Api/AdminConsole/Controllers/PoliciesController.cs: 78 |
|
CSRF | /src/Api/AdminConsole/Controllers/PoliciesController.cs: 61 |
|
CSRF | /bitwarden_license/src/Sso/Controllers/AccountController.cs: 163 |
|
CSRF | /bitwarden_license/src/Sso/Controllers/AccountController.cs: 96 |
|
CSRF | /bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: 50 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 161 |
|
CSRF | /src/Api/Auth/Controllers/EmergencyAccessController.cs: 159 |
|
CSRF | /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98 |
|
CSRF | /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 563 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 563 |
|
CSRF | /src/Api/Controllers/SettingsController.cs: 36 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 438 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 284 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 728 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1080 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 997 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 997 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 222 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 205 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 959 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 911 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 299 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 193 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 766 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1100 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 550 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 613 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 303 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 411 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 878 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 323 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 244 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 222 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 807 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 288 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 375 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 284 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 187 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 159 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 362 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 222 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 702 |
|
CSRF | /src/Api/Auth/Controllers/TwoFactorController.cs: 403 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 193 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 408 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 128 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 900 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 571 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 174 |
|
CSRF | /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 308 |
|
CSRF | /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 232 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 77 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 316 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 411 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 150 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 150 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 586 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 433 |
|
CSRF | /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 175 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 42 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 375 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1023 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1023 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 188 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 805 |
|
CSRF | /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 188 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 791 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 144 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 550 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 303 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 607 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 607 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1046 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1046 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 313 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 244 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 114 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 230 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 331 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 590 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 86 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 216 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 298 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 942 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 187 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 127 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 156 |
|
CSRF | /src/Identity/Controllers/AccountsController.cs: 72 |
|
CSRF | /src/Identity/Controllers/AccountsController.cs: 50 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 196 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 125 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 111 |
|
CSRF | /src/Api/Auth/Controllers/AccountsController.cs: 560 |
|
CSRF | /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 59 |
|
CSRF | /src/Api/Tools/Controllers/ImportCiphersController.cs: 66 |
|
CSRF | /src/Api/Tools/Controllers/ImportCiphersController.cs: 50 |
|
CSRF | /src/Api/Public/Controllers/CollectionsController.cs: 64 |
|
CSRF | /src/Admin/AdminConsole/Controllers/ProviderOrganizationsController.cs: 38 |
|
CSRF | /src/Api/Auth/Controllers/WebAuthnController.cs: 130 |
|
CSRF | /src/Api/Auth/Controllers/WebAuthnController.cs: 101 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 1100 |
|
CSRF | /src/Api/Vault/Controllers/CiphersController.cs: 659 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 117 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 89 |
|
CSRF | /src/Api/Controllers/CollectionsController.cs: 375 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 75 |
|
CSRF | /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 331 |
|
CSRF | /src/Api/AdminConsole/Controllers/GroupsController.cs: 145 |
|
CSRF |
More results are available on AST platform
