server icon indicating copy to clipboard operation
server copied to clipboard

[PM-6028] Enable features that are already in use by the official instance

Open MSDNicrosoft opened this issue 1 year ago • 3 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Same as in Gitter

Enable features that are already in use by the official instance:

  • KeyRotationImprovements
  • AutofillOverlay
  • AutofillV2
  • PasswordlessLogin
  • DisplayLowKdfIterationWarning

I've found that these features are enabled in the official instance (https://vault.bitwarden.com/api/config or https://vault.bitwarden.eu/api/config), but not in the self-hosted instance.

In addition, some of these features that can be perceived by the user have been written in documentation:

AutofillOverlay

PasswordlessLogin

Code changes

  • src/Core/Constants.cs: Set some features flags to true

Note: AutofillOverlay requires AutofillV2.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

MSDNicrosoft avatar Feb 02 '24 09:02 MSDNicrosoft

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 02 '24 09:02 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-6028

bitwarden-bot avatar Feb 02 '24 09:02 bitwarden-bot

Logo Checkmarx One – Scan Summary & Details22e237a9-c968-4e6a-b150-4b6171985d03

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 02 '24 10:02 bitwarden-bot