server icon indicating copy to clipboard operation
server copied to clipboard

[PS-1934] chore: Add national cloud endpoints for Microsoft

Open GeekCornerGH opened this issue 3 years ago • 2 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

I just added Azure AD authentication endpoints for China and USA national cloud, as shown here

Code changes

  • src/Core/Utilities/StaticStore.cs: Add "microsoftonline.us" and "microsoftonline.cn" into the Microsoft list

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

GeekCornerGH avatar Nov 29 '22 10:11 GeekCornerGH

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 29 '22 10:11 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1934

bitwarden-bot avatar Nov 29 '22 10:11 bitwarden-bot

Hi @GeekCornerGH , after internal discussions, we decided not to go forward in merging this PR. It poses a security risk for us for now as we do not know if the site(s) are safe, and we would need to validate these and all other global domains submitted, which might take up some internal capacity. We are currently looking into ways to take this burden off the community as we look to keep these domains up-to date. You can add the custom equivalent domains personally for now, as outlined here .This PR will now be closed.

dbosompem avatar Jun 28 '23 10:06 dbosompem