server icon indicating copy to clipboard operation
server copied to clipboard

[PS-1348] Added Atlassian global equivalent domain

Open Denperidge opened this issue 2 years ago • 1 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

I've added a global equivalent domain for Atlassian accounts, based on information gotten from the Atlassian support page!

This of course does not include services that have their pages on an Atlassian subdomain, for example confluence.atlassian.com.

Code changes

  • StaticStore.cs: Added domains that use Atlassian's account system
  • GlobalEquivalentDomainsType.cs: Updated enums to reflect other global equivalent domains

Before you submit

- [X] I have checked for formatting errors (`dotnet format --verify-no-changes`) (required)
- [ ] If making database changes - I have also updated Entity Framework queries and/or migrations
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

Denperidge avatar Aug 21 '22 20:08 Denperidge

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1348

bitwarden-bot avatar Aug 21 '22 20:08 bitwarden-bot

No problem! My apologies myself for my slow reaction in turn. The merge was getting a bit messy, so I synced the fork aaaand that accidentally closed the PR 😭 re-opened one on #2361 , sorry for the mess!

Denperidge avatar Oct 25 '22 14:10 Denperidge

@Denperidge: No problem at all, and thank you for circling back on the feedback. I'll get that new PR queued up for review.

djsmith85 avatar Oct 25 '22 16:10 djsmith85