server icon indicating copy to clipboard operation
server copied to clipboard

[PS-1185] Add CreationDate to CipherResponse

Open frankeld opened this issue 2 years ago • 1 comments

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Includes CreationDate in CipherResponse so the data is included in API responses.

Screenshot: image Network response from GET | https://localhost:8080/api/sync?excludeDomains=true now returns creationDate.

Code changes

  • src/Api/Models/Response/CipherResponseModel.cs: Added cipher.CreationDate

Before you submit

- [x] I have checked for formatting errors (`dotnet format --verify-no-changes`) (required)
- [NA] If making database changes - I have also updated Entity Framework queries and/or migrations
- [NA] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [NA] This change requires a **documentation update** (notify the documentation team)
- [NA] This change has particular **deployment requirements** (notify the DevOps team)

frankeld avatar Jul 25 '22 14:07 frankeld

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1185

bitwarden-bot avatar Jul 25 '22 14:07 bitwarden-bot

Actually, @frankeld would you mind merging in master branch changes? I got too excited...

Once done we can get this moved forward along with https://github.com/bitwarden/clients/pull/3181

MGibson1 avatar Sep 23 '22 15:09 MGibson1

Awesome, Thanks for this! I think this is a totally natural addition 😄

MGibson1 avatar Oct 12 '22 01:10 MGibson1